[PATCH] D109192: [WIP/DNM] Support: introduce public API annotation support

Sun Sep 5 13:40:30 PDT 2021

compnerd added a comment.

In D109192#2984318 <https://reviews.llvm.org/D109192#2984318>, @lebedev.ri wrote:

> FWIW, i personally think that the current set of libs BUILD_SHARED_LIBS produces should not change, it's intentional that way, to both be fast and fine-grained.
> And LLVM_BUILD_DYLIB is also intentionally producing a huge monolithic library, so that only a single library needs to be dlopened for speed reasons.
> IIRC someone from MLIR also wanted to do something about library restructurization, i would suggest to talk to them.
>
> All that being said, if either BUILD_SHARED_LIBS or LLVM_BUILD_DYLIB is being changed from what they are now,
> i think this requires an RFC to llvm-dev with precise explanation of what why and how,
> and why it's okay to regress existing granularity/speed/performance expectations.

This change has no impact on what `BUILD_SHARED_LIBS` does.  It does however fix the current problem that LLVMSupport on WIndows when built as a shared library has no public functions and on ELF and MachO targets exports everything.  Instead, this will explicitly control the public surface of the library's interface when built as a shared library.

There are similar changes that will be needed to support building LLVM as a shared library, but that is a separate larger change and I have no intention of merging that change into this change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109192/new/

https://reviews.llvm.org/D109192