[PATCH] D109295: [X86] Handle inverted inputs when matching VPTERNLOG from 2 binary ops.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 5 10:44:45 PDT 2021


RKSimon added a comment.

LGTM but @pengfei might have seen some other cases that D109273 <https://reviews.llvm.org/D109273> would address.



================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:4052
+  assert(B.isOperandOf(ParentB));
+  assert(C.isOperandOf(ParentC));
 
----------------
Missing assert messages


================
Comment at: llvm/test/CodeGen/X86/avx512vl-logic.ll:989
+  ret <4 x i32> %c
+}
+
----------------
Please can you precommit this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109295/new/

https://reviews.llvm.org/D109295



More information about the llvm-commits mailing list