[PATCH] D109288: [AggresiveInstCombine] Add wrapper calls for `KnownBits` computing

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 5 07:58:26 PDT 2021


anton-afanasyev marked an inline comment as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombineInternal.h:111
+    return llvm::computeKnownBits(V, DL, /*Depth=*/0, /*AC=*/nullptr,
+                                  /*CtxI=*/cast<Instruction>(CurrentTruncInst),
+                                  &DT);
----------------
lebedev.ri wrote:
> Ugh. And phab ate my comment yet again.
> Let's not add CtxI here, but in a patch that requires it.
Sure. `CtxI` isn't used without `AC` anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109288/new/

https://reviews.llvm.org/D109288



More information about the llvm-commits mailing list