[PATCH] D109192: [WIP/DNM] Support: introduce public API annotation support

Sat Sep 4 11:27:52 PDT 2021

compnerd added inline comments.

================
Comment at: llvm/lib/Support/CMakeLists.txt:104

-add_llvm_component_library(LLVMSupport
+add_llvm_component_library(LLVMSupport SHARED
   AArch64TargetParser.cpp
----------------
rnk wrote:
> As I understand it, this makes the support library always shared. I don't think that gives people using the traditional static build a pathway to transition. What I had in mind was making this conditional on LLVM_BUILD_DYLIB or whatever we're calling it, the one that builds libLLVM.so, the one all the Linux distros use.
> 
> I think our long term goal should be to align the default LLVM cmake build configuration with the one that distributors are using. The fact that most devs don't use the most commonly distributed LLVM build configuration leads to surprises like the ones from earlier this year:
> https://maskray.me/blog/2021-05-16-elf-interposition-and-bsymbolic
> https://lore.kernel.org/lkml/CAHk-=whs8QZf3YnifdLv57+FhBi5_WeNTG1B-suOES=RcUSmQg@mail.gmail.com/
> 
You are correct, and this hunk is not something we can check in.  However, it is the fastest way to burn through the annotations.  Once we have the annotations correct, tweaking the build to match the correct behaviour is a simpler task.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109192/new/

https://reviews.llvm.org/D109192