[PATCH] D109203: [X86] Don't clobber EBX in stackprobes

Fri Sep 3 19:01:05 PDT 2021

pengfei added inline comments.

================
Comment at: llvm/test/CodeGen/X86/stack-clash-large.ll:2
 ; RUN: llc -mtriple=x86_64-linux-android < %s | FileCheck -check-prefix=CHECK-X86-64 %s 
 ; RUN: llc -mtriple=i686-linux-android < %s | FileCheck -check-prefix=CHECK-X86-32 %s 

----------------
We'd better add a RUN for the X64-32 case. How about
```
; RUN: llc -mtriple=x86_64-linux-android < %s | FileCheck -check-prefix=CHECK-X64 %s 
; RUN: llc -mtriple=i686-linux-android < %s | FileCheck -check-prefix=CHECK-X86 %s 
; RUN: llc -mtriple=x86_64-linux-gnux32 < %s | FileCheck -check-prefix=CHECK-X32 %s 
```
We prefer to use prefix "X32" for the X64-32 case only and use X86 for the common 32 bit case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109203/new/

https://reviews.llvm.org/D109203