[PATCH] D106989: [IRSim] Finding Branch Similarity

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1361
+  IRInstructionDataList::iterator NextIDIt = std::next(ID.getIterator());
+  Instruction *NextIDLInst = NextIDIt->Inst;
+  Instruction *NextModuleInst = nullptr;
----------------
Can NextIDIt be the end/one past the end? Is this accessible in those cases?


================
Comment at: llvm/test/Transforms/IROutliner/region-end-of-module.ll:3
+; RUN: opt -S -verify -iroutliner -ir-outlining-no-cost < %s | FileCheck %s
+
+; This test checks that we do not fail when there is a similarity group with
----------------
each of the cases here end in a `br`.

What about `unreachable` and `ret`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106989/new/

https://reviews.llvm.org/D106989