[PATCH] D109257: [SimpleLoopUnswitch] Inform pass manager when child loops are deleted

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/nontrivial-unswitch-markloopasdeleted.ll:1
+; RUN: opt < %s -enable-loop-distribute -passes='loop-distribute,loop-mssa(simple-loop-unswitch<nontrivial>),loop-distribute' -o /dev/null -S -debug-pass-manager=verbose 2>&1 | FileCheck %s
+
----------------
bjope wrote:
> aeubanks wrote:
> > maybe to simplify this a bit you could just do `require<access-info>` instead of running a full optimization pass that uses it. it'd make this test a bit more robust
> Well, I had the same idea. But decided not to do like that in the end.
> 
> My original problem was related to loop-distribute, which is a function pass. So in that situation there is a LoopAnalysisManagerFunctionProxy involved. If using require<access-info>, then I got the impression that things might be a bit different. But given that we basically only want to see that there is a "Clearing all analysis results" for the destroyed loop, then maybe it is ugly to use loop-distribute here.
Ah makes sense. Yeah I think checking for the "Clearing all analysis results" is sufficient


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109257/new/

https://reviews.llvm.org/D109257