[PATCH] D109192: [WIP/DNM] Support: introduce public API annotation support

Fri Sep 3 14:46:10 PDT 2021

compnerd added a comment.

In D109192#2983153 <https://reviews.llvm.org/D109192#2983153>, @mstorsjo wrote:

> In D109192#2983146 <https://reviews.llvm.org/D109192#2983146>, @aganea wrote:
>
>> There's a 2^16 symbol limit per DLL on Windows, so exporting entire classes would potentially reach that limit much faster.
>
> FWIW, in mingw configurations, the existing dylib setup works (as mingw toolchains fall back to exporting all symbols if there's no dllexports). libLLVM is cutting it quite close though, it currently ends up at 58000 symbols, so not many to spare (and this with only X86, ARM and AArch64 targets enabled, I think it ends up too many if all targets are enabled, and if building with asserts enabled, there's a couple more too).

That is both good and bad.  Its good to know that we are able to get a build with everything exported, though I think that we will want to be able to include all the targets, and might be too close to that limit.  However, I suspect that splitting up LLVM.dll into LLVM.dll and LLVMSupport.dll we might be able to scrape through.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109192/new/

https://reviews.llvm.org/D109192