[PATCH] D109134: [MemorySSA] Support invariant.group metadata

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 12:54:29 PDT 2021


aeubanks added a comment.

Piotr and I looked over the NewGVN test and there were some interesting missed NewGVN optimizations. These seem like things to be fixed on the NewGVN side.

1. NewGVN was correctly forwarding a stored value to a load, but wasn't calling instsimplify on that. In these cases, we were loading a function from a vtable definition which instsimplify got, but that wasn't happening with newgvn
2. NewGVN has trouble CSE'ing loads with different pointee types
3. NewGVN doesn't support assumes in some cases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109134/new/

https://reviews.llvm.org/D109134



More information about the llvm-commits mailing list