[PATCH] D102266: Recommit "[LAA] Support pointer phis in loop by analyzing each incoming pointer."

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 12:46:44 PDT 2021


Meinersbur added a comment.

Should the PHINode itself also be added to the Accesses list? Or is there a guarantee that it is never queried?



================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:1274
+    for (const Use &Inc : PN->incoming_values())
+      AddPointer(Inc);
+  } else
----------------
Should this be recursive, the incoming value might be a PHI inside the InnermostLoop as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102266/new/

https://reviews.llvm.org/D102266



More information about the llvm-commits mailing list