[PATCH] D109253: [AArch64] Emit some .cfi_* for non-SVE cases in emitEpilogue
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 3 12:37:51 PDT 2021
MaskRay added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1688
AArch64FunctionInfo *AFI = MF.getInfo<AArch64FunctionInfo>();
+ // TODO Also emit CFI when SVECalleeSavedStackSize != 0.
+ bool NeedsDwarfCFI = MF.getTarget().getTargetTriple().isOSBinFormatELF() &&
----------------
SVE callee save stack seems very difficult, so not in the scope of this patch.
================
Comment at: llvm/test/CodeGen/AArch64/fptosi-sat-vector.ll:279
; CHECK-NEXT: fmov s0, w8
+; CHECK-NEXT: .cfi_adjust_cfa_offset 16
; CHECK-NEXT: add sp, sp, #32
----------------
This is incorrect.
================
Comment at: llvm/test/CodeGen/AArch64/fptosi-sat-vector.ll:1490
; CHECK-NEXT: fmov x0, d0
+; CHECK-NEXT: .cfi_adjust_cfa_offset 16
+; CHECK-NEXT: .cfi_adjust_cfa_offset 16
----------------
This is apparently incorrect.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109253/new/
https://reviews.llvm.org/D109253
More information about the llvm-commits
mailing list