[PATCH] D106989: [IRSim] Finding Branch Similarity

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken marked an inline comment as done.
AndrewLitteken added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1363
+  Instruction *NextInst = nullptr;
+  if (!ID.Inst->isTerminator())
+    NextInst = ID.Inst->getNextNonDebugInstruction();
----------------
paquette wrote:
> Just use `NextIDInst` here?
That would be using the next instruction in the list, this is checking what the current instruction that was passed in.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1365
+    NextInst = ID.Inst->getNextNonDebugInstruction();
+  else if (IDIt->Inst != nullptr)
+    NextInst =
----------------
paquette wrote:
> Same here?
I'll change it for this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106989/new/

https://reviews.llvm.org/D106989