[PATCH] D109252: Add extra check for llvm::Any::TypeId visibility

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:81
+      add_custom_target(check-typeid-visibility
+        COMMAND nm -C ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM-${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX}${CMAKE_SHARED_LIBRARY_SUFFIX} | ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/not grep -E '[wW] llvm::Any::TypeId'
+        DEPENDS LLVM not
----------------
This should use llvm-nm.

Also, can you make it into a lit test like this one:
https://github.com/llvm/llvm-project/tree/main/clang/test/LibClang


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109252/new/

https://reviews.llvm.org/D109252