[PATCH] D109128: [VFS] Use original path when falling back to external FS

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 11:07:57 PDT 2021


keith added a comment.

In D109128#2982780 <https://reviews.llvm.org/D109128#2982780>, @JDevlieghere wrote:

> I'm sure I'm missing something, but after rereading the patch several times I still don't see the functional change. It just looks like it's renaming every instance of `Path` to `CanonicalPath` and `Path_` to `Path`?

The functional change is not changing line 2016 and 2029 to use the newly named `CanonicalPath` when they did before. This was a bit more clear before I changed that variable name (but this is overall better IMO)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109128/new/

https://reviews.llvm.org/D109128



More information about the llvm-commits mailing list