[PATCH] D108877: [WebAssembly] Allow import and export of TLS symbols between DSOs

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

It would be great to have tests for the new subsections.



================
Comment at: lld/wasm/SyntheticSections.cpp:79
+  for (const Symbol *sym : out.importSec->importedSymbols) {
+    if (sym->isWeak()) {
+      importInfo.push_back(sym);
----------------
Why do we check `sym->isTLS()` for exports but not for imports?


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1566-1567
+  // Unsupported TLS modes
+  assert(model != GlobalValue::NotThreadLocal);
+  assert(model != GlobalValue::InitialExecTLSModel);
 
----------------
Should these asserts be `report_fatal_error`s instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108877/new/

https://reviews.llvm.org/D108877