[PATCH] D108512: [flang][OpenMP] Add semantic checks for ordered construct

Peixin Qiao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 09:25:52 PDT 2021


peixin updated this revision to Diff 370601.
peixin added a comment.

@kiranchandramohan Thanks for your review. Delete `SOURCE` and `SINK` in dependence type in parser.

The comment what I am referring to is the last inline comment @clementval added as follows:

  flang/lib/Semantics/check-omp-structure.cpp
  891
  What is the final reason to not use FindClause? It would be more efficient than iterate over the clause list once more.

It's in the function OmpStructureChecker::ChecksOnOrderedAsStandalone.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108512/new/

https://reviews.llvm.org/D108512

Files:
  flang/include/flang/Parser/parse-tree.h
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/lib/Semantics/resolve-directives.cpp
  flang/test/Semantics/omp-clause-validity01.f90
  llvm/include/llvm/Frontend/OpenMP/OMP.td
  test/Semantics/omp-ordered01.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108512.370601.patch
Type: text/x-patch
Size: 11629 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210903/131d9ea5/attachment.bin>


More information about the llvm-commits mailing list