[PATCH] D108122: FunctionAttrs: do not mark coroutines with odd return path `noreturn`

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 08:49:13 PDT 2021


jdoerfert added a comment.

This sounds weird. Trying to map this to "regular semantics" coro_end seems to be able to unwind in a way that can happen also in `nounwind` contexts. I'd assume that can probably break the next few implicit assumptions somewhere.
Is there a reason we don't branch to a return on from the coro_end depending on the result?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108122/new/

https://reviews.llvm.org/D108122



More information about the llvm-commits mailing list