[PATCH] D109236: [AggressiveInstCombine] Add vector instructions to `TruncInstCombine` DAG

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 08:46:23 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/TruncInstCombine.cpp:436
+          V1, V2, cast<ShuffleVectorInst>(I)->getShuffleMask());
+      break;
+    }
----------------
Are we allowed to create new shuffles inside aggressiveinstcombine? A different type, even with the same mask, means that this might have a very different performance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109236/new/

https://reviews.llvm.org/D109236



More information about the llvm-commits mailing list