[PATCH] D109192: [WIP/DNM] Support: introduce public API annotation support

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 08:27:26 PDT 2021


hans added a comment.

In D109192#2982429 <https://reviews.llvm.org/D109192#2982429>, @compnerd wrote:

> One question that remains is the spelling of the macro.  Do we want to go with `API` or `ABI`?  I think that there is an argument to be made that `ABI` is more precise - this marks how you call into the library not just how you use it.  When a function is moved beyond the module boundary, while the API will not change, the ABI of the module would.  This of course pedantic, but these items are important to nail down correctly early as these are fairly large scale invasive changes.

I've seen `*API` macros used for this in other libraries, but I don't think I've ever seen the `*ABI` variant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109192/new/

https://reviews.llvm.org/D109192



More information about the llvm-commits mailing list