[PATCH] D109216: [LNT] Fixed fieldchanges grouping to a regression

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre accepted this revision.
thopre added a comment.
This revision is now accepted and ready to land.

LGTM with the description update



================
Comment at: lnt/server/db/fieldchange.py:269
 
-    new_reg, new_indicators = new_regression(session, ts, [fc.id])
+    new_reg, new_indicators = new_regression(session, ts, [fc])
     logger.info("Could not find a partner, creating new Regression for change: {}".format(new_reg.title))
----------------
slydiman wrote:
> thopre wrote:
> > Why is this change correct / needed?
> It seems 2 months ago it was a bug fix for missing session.flush() in line 175. 
> Now it is just a performance optimization. 
> Note the method new_regression() allows the fieldchange id (requires additional query to DB) or the fieldchange object itself (faster).
Ah I see. Would you mind mentioning it in the patch description?


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109216/new/

https://reviews.llvm.org/D109216