[PATCH] D109217: [NOT FOR COMMIT] [llvm-dwarfdump] Fix unsigned overflow when calculating stats

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 02:44:13 PDT 2021


djtodoro created this revision.
djtodoro added reviewers: dblaikie, akhuang.
djtodoro added projects: debug-info, LLVM.
Herald added subscribers: dexonsmith, cmtice, hiraditya.
Herald added a reviewer: jhenderson.
djtodoro requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.

This fixes https://bugs.llvm.org/show_bug.cgi?id=51652.

The idea is to bump all the stat field to 64-bit wide unsigned integers. I've confirmed this resolves the use case for chromium.

TODO: Split JSON and llvm-dwarfdump changes into multiple patches, and add a test cases.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109217

Files:
  llvm/include/llvm/Support/JSON.h
  llvm/lib/Support/JSON.cpp
  llvm/tools/llvm-dwarfdump/Statistics.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109217.370519.patch
Type: text/x-patch
Size: 13062 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210903/b1de653a/attachment.bin>


More information about the llvm-commits mailing list