[PATCH] D108978: [NFC] [LoopDeletion] Move ICmpInst handling to getValueOnFirstIteration()

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:329
+      auto *ICmp = dyn_cast<ICmpInst>(Cond);
+      if (!ICmp || !ICmp->getType()->isIntegerTy()) {
         MarkAllSuccessorsLive(BB);
----------------
reames wrote:
> As a follow up, it looks like this test is now redundant for the new code structure.  Only part I'm unsure of is the integer test, but I also don't understand why that's there at all.  
You're right, vector type should not pass the matcher. We'll remove it in a follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108978/new/

https://reviews.llvm.org/D108978