[PATCH] D109192: [WIP/DNM] Support: introduce public API annotation support

Joachim Meyer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 01:25:15 PDT 2021


fodinabor added a comment.

Thanks for working on this!
In general looks good to me, I'd opt for all CAPS macros, though, so e.g. `LLVM_SUPPORT_API`. The return variant `LLVM_SUPPORT_API(retTy)` is only beneficial when needing something like `extern "C" retTy __stdcall` iirc and is less ideal for marking classes as exported.
A parameterized version `LLVM_API(LLVMSupport)` would be fine for me as well, although I don't see any benefit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109192/new/

https://reviews.llvm.org/D109192



More information about the llvm-commits mailing list