[PATCH] D109193: [sanitizer_common] Define wordexp_wrde_dooffs for Solaris

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In D109193#2981390 <https://reviews.llvm.org/D109193#2981390>, @justincady wrote:

> Thanks for fixing this, and I apologize that I missed this platform as well.

Thanks.  However, I'd argue that the fault primarily lies with the way `compiler-rt` is configured:

- The `wordexp` interceptor in `sanitizer_common_interceptors.inc` is guarded with `SANITIZER_INTERCEPT_WORDEXP` while...
- ... we have 3 declarations/definitions now of `wordexp_wrde_dooffs`: one in `sanitizer_platform_limits_posix.h/.cpp`, which despite the filename is Linux and macOS only and now two more in `sanitizer_platform_limits_freebsd.h/.cpp` and `sanitizer_platform_limits_solaris.h/.cpp`.

It's almost impossible not to get lost in that impenetrable maze.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109193/new/

https://reviews.llvm.org/D109193