[PATCH] D109185: [gn build] Add build files for LLDB

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 18:27:22 PDT 2021


thakis added a comment.

This fixes that one PPC64 test. I guess the other plugins in Architecture/ aren't covered by shell tests...

  $ git diff HEAD
  diff --git a/llvm/utils/gn/secondary/lldb/source/Plugins/Architecture/PPC64/BUILD.gn b/llvm/utils/gn/secondary/lldb/source/Plugins/Architecture/PPC64/BUILD.gn
  new file mode 100644
  index 000000000000..177620783e8d
  --- /dev/null
  +++ b/llvm/utils/gn/secondary/lldb/source/Plugins/Architecture/PPC64/BUILD.gn
  @@ -0,0 +1,14 @@
  +static_library("PPC64") {
  +  output_name = "lldbPluginArchitecturePPC64"
  +  configs += [ "//llvm/utils/gn/build:lldb_code" ]
  +  deps = [
  +    "//lldb/source/Core",
  +    "//lldb/source/Target",
  +    "//lldb/source/Utility",
  +    "//lldb/source/Plugins/Process/Utility",
  +    "//llvm/lib/Support",
  +  ]
  +  # Uses source-relative paths for own includes.
  +  include_dirs = [ "//lldb/source" ]
  +  sources = [ "ArchitecturePPC64.cpp" ]
  +}
  diff --git a/llvm/utils/gn/secondary/lldb/source/Plugins/BUILD.gn b/llvm/utils/gn/secondary/lldb/source/Plugins/BUILD.gn
  index 35149476aff6..219b0732bc25 100644
  --- a/llvm/utils/gn/secondary/lldb/source/Plugins/BUILD.gn
  +++ b/llvm/utils/gn/secondary/lldb/source/Plugins/BUILD.gn
  @@ -5,6 +5,7 @@ import("//llvm/utils/gn/build/write_cmake_config.gni")
   plugins = [
     "ABIPowerPC",
     "ABIX86",
  +  "ArchitecturePPC64",
     "DisassemblerLLVMC",
     "DynamicLoaderDarwinKernel",
     "DynamicLoaderMacOSXDYLD",
  diff --git a/llvm/utils/gn/secondary/lldb/tools/driver/BUILD.gn b/llvm/utils/gn/secondary/lldb/tools/driver/BUILD.gn
  index 22dc74e0b98b..8455ba4751c9 100644
  --- a/llvm/utils/gn/secondary/lldb/tools/driver/BUILD.gn
  +++ b/llvm/utils/gn/secondary/lldb/tools/driver/BUILD.gn
  @@ -20,6 +20,7 @@ executable("lldb") {
       # FIXME: in the cmake build these come in from elsewhere
       "//lldb/source/Plugins/ABI/PowerPC",
       "//lldb/source/Plugins/ABI/X86",
  +    "//lldb/source/Plugins/Architecture/PPC64",
       "//lldb/source/Plugins/Disassembler/LLVMC",
       "//lldb/source/Plugins/DynamicLoader/MacOSX-DYLD",
       "//lldb/source/Plugins/DynamicLoader/POSIX-DYLD",
  diff --git a/llvm/utils/gn/secondary/lldb/tools/lldb-test/BUILD.gn b/llvm/utils/gn/secondary/lldb/tools/lldb-test/BUILD.gn
  index 7f67be94ad1c..1e2a7f67bb79 100644
  --- a/llvm/utils/gn/secondary/lldb/tools/lldb-test/BUILD.gn
  +++ b/llvm/utils/gn/secondary/lldb/tools/lldb-test/BUILD.gn
  @@ -24,6 +24,7 @@ executable("lldb-test") {
   
       # FIXME: in the cmake build these come in from elsewhere
       # FIXME: also, don't duplicate this in driver and lldb-test
  +    "//lldb/source/Plugins/Architecture/PPC64",
       "//lldb/source/Plugins/ABI/PowerPC",
       "//lldb/source/Plugins/ABI/X86",
       "//lldb/source/Plugins/Disassembler/LLVMC",
  diff --git a/llvm/utils/gn/secondary/lldb/tools/lldb-vscode/BUILD.gn b/llvm/utils/gn/secondary/lldb/tools/lldb-vscode/BUILD.gn
  index 1ba744912d4e..deebb31fbaf5 100644
  --- a/llvm/utils/gn/secondary/lldb/tools/lldb-vscode/BUILD.gn
  +++ b/llvm/utils/gn/secondary/lldb/tools/lldb-vscode/BUILD.gn
  @@ -15,6 +15,7 @@ executable("lldb-vscode") {
   
       # FIXME: in the cmake build these come in from elsewhere
       # FIXME: also, don't duplicate this in driver and lldb-test and lldb-vscode
  +    "//lldb/source/Plugins/Architecture/PPC64",
       "//lldb/source/Plugins/ABI/PowerPC",
       "//lldb/source/Plugins/ABI/X86",
       "//lldb/source/Plugins/Disassembler/LLVMC",


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109185/new/

https://reviews.llvm.org/D109185



More information about the llvm-commits mailing list