[PATCH] D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 16:26:26 PDT 2021


aardappel added a comment.

Well.. yes :) The code runs, and unlike before, causes all symbols for all functions to be collected before MCLowering.
It passes all existing tests that expect __stack_pointer, and the new test fails without this patch because the .globaltype is not emitted, much like in the reported bug.
Do you recommend anyone to add to this review to see if I am not committing a grave LLVM-no-no?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109202/new/

https://reviews.llvm.org/D109202



More information about the llvm-commits mailing list