[PATCH] D109196: scudo: Only add no-omit-frame-pointer flags when the compiler supports them

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 14:24:31 PDT 2021


tstellar created this revision.
tstellar added reviewers: cryptoad, dvyukov.
Herald added a subscriber: mgorny.
tstellar requested review of this revision.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109196

Files:
  compiler-rt/lib/scudo/standalone/CMakeLists.txt


Index: compiler-rt/lib/scudo/standalone/CMakeLists.txt
===================================================================
--- compiler-rt/lib/scudo/standalone/CMakeLists.txt
+++ compiler-rt/lib/scudo/standalone/CMakeLists.txt
@@ -124,8 +124,10 @@
        RTGwpAsan RTGwpAsanBacktraceLibc RTGwpAsanSegvHandler
        RTGwpAsanOptionsParser)
 
-  list(APPEND SCUDO_CFLAGS -DGWP_ASAN_HOOKS -fno-omit-frame-pointer
-                           -mno-omit-leaf-frame-pointer)
+  append_list_if(COMPILER_RT_HAS_OMIT_FRAME_POINTER_FLAG -fno-omit-frame-pointer
+                 SCUDO_CFLAGS)
+  list(APPEND SCUDO_CFLAGS -DGWP_ASAN_HOOKS)
+
 endif()
 
 set(SCUDO_LINK_LIBS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109196.370410.patch
Type: text/x-patch
Size: 666 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210902/8000b7b9/attachment.bin>


More information about the llvm-commits mailing list