[PATCH] D106989: [IRSim] Finding Branch Similarity

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:734
+
+    if (ItA->RelativeBlockLocations.size() !=
+            ItB->RelativeBlockLocations.size() &&
----------------
`ItA->RelativeBlockLocations` and `ItB->RelativeBlockLocations` into variables? Then you can reuse them in the `zip` below.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:739
+
+    detail::zippy<detail::zip_shortest, SmallVector<int, 4> &,
+                  SmallVector<int, 4> &, ArrayRef<Value *> &,
----------------
can you use a typedef for this?

like `ZippedRelativeLocationsT` or something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106989/new/

https://reviews.llvm.org/D106989