[PATCH] D108656: [IROutliner] Using Canonical Values to find Corresponding Items between Regions

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/IROutliner.h:166
+  /// exists, otherwise None.
+  Optional<Value *> findCorrespondingValueIn(const OutlinableRegion &Other,
+                                             Value *V);
----------------
jroelofs wrote:
> I'd drop the `Optional<>` and use nullptr to represent "didn't find one". That removes ambiguity around `Optional<Value*>(nullptr)`, and would improve the call sites.
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108656/new/

https://reviews.llvm.org/D108656