[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

Thu Sep 2 12:29:52 PDT 2021

thakis added a comment.

In D109167#2980604 <https://reviews.llvm.org/D109167#2980604>, @GMNGeoffrey wrote:

>> I had fixed this in https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f . Precommit bot on this change was green though as far as I can tell.
>
> Harbormaster comments with a green check mark that build has completed, but if you look at the top of the revision it has the build results.

Thanks, I didn't realize this. I thought this passed precommit, else I wouldn't have landed it.

Perfectly fine to revert things that break the build of course. Timing was a bit unfortunate, but reverting broken things is of course A-ok (especially with failing pre-merge testing). Thanks for relanding :)

> For some reason that I don't understand, the actual status at the top disappears as soon as the commit has landed, which is... very unhelpful. If you click on the Harbormaster comment now, you can see that they failed. I've reopened a diff with https://reviews.llvm.org/D109181 and will reland if premerge checks pass. Sorry that my revert went past the fix. AFAIU, I was following the guidelines in https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy. I think it would be nice to comment on the review that you are already preparing a fix (but I have no idea what the standard practice is). If I had known you were then I wouldn't have reverted.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109167/new/

https://reviews.llvm.org/D109167