[PATCH] D109019: [CMake] Add targets for generating coverage reports

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/cmake/modules/CoverageReport.cmake:18
+if(NOT LLVM_COV OR NOT LLVM_PROFDATA)
+  message(WARNING "Could not find code coverage tools, skipping generating targets. You may explicitly specify LLVM_COV and LLVM_PROFDATA to work around this warning.")
+  return()
----------------
Have you considered using `SEND_ERROR`? I'm worried that people might miss the warning and then become surprised when they don't get coverage so I'd slightly prefer error over warning.


================
Comment at: llvm/docs/CMake.rst:322
+**LLVM_CODE_COVERAGE_TARGETS**:STRING
+  If set to a semicolon separeated list of targets, those targets will be used
+  to drive the code coverage reports. If unset, the target list will be
----------------



================
Comment at: llvm/docs/CMake.rst:327
+**LLVM_COVERAGE_SOURCE_DIRS**:STRING
+  If set to a semicolon separeated list of directories, the coverage reports
+  will limit code coverage summaries to just the listed directories. If unset,
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109019/new/

https://reviews.llvm.org/D109019