[PATCH] D106235: Reformulate OrcJIT tutorial doc to make it more clear.
Yuichi Yoshida via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 2 09:43:26 PDT 2021
sonson updated this revision to Diff 370306.
sonson added a comment.
Removed "someone" expression.
I replaced the sentence pointed out by three reviewers with the current one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106235/new/
https://reviews.llvm.org/D106235
Files:
llvm/docs/tutorial/BuildingAJIT2.rst
Index: llvm/docs/tutorial/BuildingAJIT2.rst
===================================================================
--- llvm/docs/tutorial/BuildingAJIT2.rst
+++ llvm/docs/tutorial/BuildingAJIT2.rst
@@ -229,7 +229,7 @@
interface that ORC can call as needed. The add method takes an
module in some input program representation (in this case an LLVM IR module)
and stores it in the target ``JITDylib``, arranging for it to be passed back
-to layer's emit method when someone requests any symbols defined by the module.
+to layer's emit method when any symbol defined by that module is requested.
Each layer can complete its own work by calling the ``emit`` method of its base
layer. For example, in this tutorial our IRTransformLayer calls through to
our IRCompileLayer to compile the transformed IR, and our IRCompileLayer in
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106235.370306.patch
Type: text/x-patch
Size: 827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210902/3b49c63c/attachment.bin>
More information about the llvm-commits
mailing list