[PATCH] D109166: [llvm-profgen] Turn off cold context trimming by default

[Wenlei He via Phabricator via llvm-commits]

wenlei created this revision.
wenlei added reviewers: hoy, wmi, wlei.
Herald added subscribers: modimo, lxfind.
wenlei requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We merge cold context by default to save profile size. However trimming cold context after merging doesn't save size much, so default to off to reflect how it's commonly used.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109166

Files:
  llvm/tools/llvm-profgen/ProfileGenerator.cpp


Index: llvm/tools/llvm-profgen/ProfileGenerator.cpp
===================================================================
--- llvm/tools/llvm-profgen/ProfileGenerator.cpp
+++ llvm/tools/llvm-profgen/ProfileGenerator.cpp
@@ -46,7 +46,7 @@
              "profile."));
 
 static cl::opt<bool> CSProfTrimColdContext(
-    "csprof-trim-cold-context", cl::init(true), cl::ZeroOrMore,
+    "csprof-trim-cold-context", cl::init(false), cl::ZeroOrMore,
     cl::desc("If the total count of the profile after all merge is done "
              "is still smaller than threshold, it will be trimmed."));
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109166.370304.patch
Type: text/x-patch
Size: 591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210902/cd5826c7/attachment.bin>