[PATCH] D75072: [SCEV] Record NI types in add exprs

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 09:36:33 PDT 2021


reames added a comment.

In D75072#2971558 <https://reviews.llvm.org/D75072#2971558>, @vtjnash wrote:

> The complexity of this design appears to have been rendered mostly irrelevant by 141e845da5dda6743a09f858b4aec0133a931453 <https://reviews.llvm.org/rG141e845da5dda6743a09f858b4aec0133a931453>, so only the new flag is needed, and not the new subclass.

Between the change you finger, and the recent changes to disallow pointer subtraction of non-integrals, I believe this case is now fully addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75072/new/

https://reviews.llvm.org/D75072



More information about the llvm-commits mailing list