[PATCH] D109104: [CSSPGO] Allow inlining recursive call for preinliner

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1290
+  // TODO: Evaluate if this is helpful for AutoFDO too in general.
+  Params.AllowRecursiveCall = ProfileIsCS && UsePreInlinerDecision;
   // Checks if there is anything in the reachable portion of the callee at
----------------
hoy wrote:
> wenlei wrote:
> > hoy wrote:
> > > Should this also be enabled for csspgo without preliner?
> > Hmm.. actually this is what it currently does. UsePreInlinerDecision is on by default for CSSPGO. So basically, we have `sample-profile-use-preinliner` indirectly controls whether we allow recursive inline. Do you think we should have separate switch just for recursive inlining? That probably makes experimenting with AutoFDO a bit easier too.
> Oh yeah, `UsePreInlinerDecision` is on by default for CSSPGO. A separate switch would be more solid like the decision won't be changed when `UsePreInlinerDecision` is off. It is also handy for experimenting with AutoFDO.
Ok, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109104/new/

https://reviews.llvm.org/D109104