[PATCH] D109116: [RISCV] Change how we encode AVL operands in vector pseudoinstructions to use GPRNoX0.
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 2 07:14:27 PDT 2021
frasercrmck added a comment.
Neat trick!
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1343
? DAG.getConstant(VecVT.getVectorNumElements(), DL, XLenVT)
- : DAG.getRegister(RISCV::X0, XLenVT);
+ : DAG.getTargetConstant(-1ULL, DL, XLenVT);
MVT MaskVT = MVT::getVectorVT(MVT::i1, ContainerVT.getVectorElementCount());
----------------
I think this sentinel may be better served as a named constant in C++. Doesn't really help the two uses in TableGen though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109116/new/
https://reviews.llvm.org/D109116
More information about the llvm-commits
mailing list