[PATCH] D109105: [clang-cl] Emit nicer warning on unknown /arch: arguments

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm, nice!



================
Comment at: llvm/include/llvm/ADT/StringMap.h:301
+  /// is inserted .
+  template <class InputIt> void insert(InputIt First, InputIt Last) {
+    for (InputIt It = First; It != Last; ++It)
----------------
nit: i think typename is more common than class in llvm code

unittests/ADT/StringMapTest.cpp has tests for the insert methods, maybe it's worth adding one for this too (or the initializer_list one perhaps) even though it's pretty trivial?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109105/new/

https://reviews.llvm.org/D109105