[PATCH] D109149: [DAG] Fold select_cc setgt X, -1, C, ~C -> xor (ashr X, BW-1), C

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 06:15:27 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:22877
+
+  // Fold select_cc seteq (ashr X, BW-1), -1, A, B -> select_cc setlt X, 0, A, B
+  if (CC == ISD::SETEQ && N0.getOpcode() == ISD::SRA &&
----------------
Shouldn't this be done in SimplifySetCC, i.e. for all setCC regardless of whether they are used in a select_cc or not?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109149/new/

https://reviews.llvm.org/D109149



More information about the llvm-commits mailing list