[PATCH] D109145: [AArch64][SVE] Workaround incorrect types when lowering fixed length gather/scatter

Bradley Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 04:17:52 PDT 2021


bsmith created this revision.
bsmith added reviewers: paulwalker-arm, peterwaller-arm, sdesmalen.
Herald added subscribers: ctetreau, psnobl, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: efriedma.
bsmith requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When lowering a fixed length gather/scatter the index type is assumed to
be the same as the memory type, this is incorrect in cases where the
extension of the index has been folded into the addressing mode.

For now add a temporary workaround to fix the codegen faults caused by
this by preventing the removal of this extension. At a later date the
lowering for SVE gather/scatters will be redesigned to improve the way
addressing modes are handled.

As a short term side effect of this change, the addressing modes
generated for fixed length gather/scatters will not be optimal.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109145

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/sve-fixed-length-masked-gather.ll
  llvm/test/CodeGen/AArch64/sve-fixed-length-masked-scatter.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109145.370225.patch
Type: text/x-patch
Size: 19634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210902/21e519ec/attachment.bin>


More information about the llvm-commits mailing list