[PATCH] D109118: [AArch64][SVE][InstCombine] Canonicalize aarch64_sve_dup_x intrinsic to IR splat operation

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

The patch looks good but please add an explicit test for the dup_x->splat transform to sve-intrinsic-opts-dup.ll.

The above failures are because many of the SVE ACLE tests use dup_x so unfortunately those will need updating as well.  I guess this is the trade off, the SVE ACLE tests use -O1 so that they can ignore local variable stack access but then it means updates are required when we canonicalising the intrinsics to LLVM constants/instructions.  Another option is to perhaps disable instcombine for those tests but I've not looked to see if that is possible, but my gut feeling is probably not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109118/new/

https://reviews.llvm.org/D109118