[PATCH] D109069: [AArch64] Avoid adding duplicate implicit operands when expanding pseudo insts.

weiwei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 02:28:53 PDT 2021


wwei added a comment.

Yes, we need to call transferImpOps here, because it will copy the implict operand include the flag--like `dead` flag.
But `BuildMI` will ignore the flag, so the changes in this MR will use `CreateMachineInstr(....   /*NoImplicit=*/true)` to avoid  adding duplicate implict operands
I will try to explain why there may have correct issues in postra scheduling later. 
The test case is updated in : https://bugs.llvm.org/show_bug.cgi?id=51711

In D109069#2978111 <https://reviews.llvm.org/D109069#2978111>, @dmgreen wrote:

> Do we need to call transferImpOps here?
> Or can we fix it directly to not add duplicate operands?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109069/new/

https://reviews.llvm.org/D109069



More information about the llvm-commits mailing list