[PATCH] D109048: [flang] COMMAND_ARGUMENT_COUNT runtime implementation

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: flang/runtime/command.cpp:1
+//===-- runtime/command.cpp -------------------------------------*- C++ -*-===//
+//
----------------
klausler wrote:
> I don't think that you need the "*- C++ *" stuff in *.cpp files, just in headers (*.h).
Right, copy-paste artifact :) It seems we have it in 23 out of 45 .cpp files in the runtime, I'll remove it from all of them.


================
Comment at: flang/runtime/command.cpp:14
+CppTypeFor<TypeCategory::Integer, 4> RTNAME(ArgumentCount)() {
+  int argc = executionEnvironment.argc;
+  if (argc > 1) {
----------------
klausler wrote:
> Braced initialization, please; it's often safer.
Sorry, muscle memory... /hides under a rock.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109048/new/

https://reviews.llvm.org/D109048