[PATCH] D107087: Fix SectionMemoryManager deconstruction error with MSVC

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 21:55:25 PDT 2021


lhames added a comment.

Hi Justice,

Thanks for your patience with this review.

In D107087#2947188 <https://reviews.llvm.org/D107087#2947188>, @justice_adams wrote:

> @lhames You are correct! I wasn't familiar with `ManagedStatic` but that does fix it. Do you prefer that approach to what's here? If so, I'll go ahead and update the diff.

Yes -- I think ManagedStatic should be preferred approach here.

- Lang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107087/new/

https://reviews.llvm.org/D107087



More information about the llvm-commits mailing list