[PATCH] D109083: [NFC][PowerPC] Small code refactor in LoopInstrFormPrep

Wed Sep 1 18:15:03 PDT 2021

shchenz accepted this revision.
shchenz added a comment.
This revision is now accepted and ready to land.

LGTM.

Thanks for doing this. I was about to commit an NFC patch for the format issues in https://reviews.llvm.org/D108750 and https://reviews.llvm.org/D105872 including this function refactor.

================
Comment at: llvm/lib/Target/PowerPC/PPCLoopInstrFormPrep.cpp:272

-static Value *GetPointerOperand(Value *MemI) {
+static Value *GetPointerOperand(Value *MemI, Type **PtrElementType = nullptr) {
+
----------------
We need to fix the clang-tidy warning. And we can not just use getPointerOperand() as the load/store instruction also has a member function named by `getPointerOperand`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109083/new/

https://reviews.llvm.org/D109083