[PATCH] D109111: [CSSPGO] Use preinliner decision by default when available

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 17:33:06 PDT 2021


wenlei added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1314
+  if (UsePreInlinerDecision &&
+      Candidate.CalleeSamples->getContext().hasAttribute(
+          ContextShouldBeInlined))
----------------
hoy wrote:
> Will non-inlined context be merged into the base profile by the preinliner? Wondering if we can have contexts without `ContextShouldBeInlined` in the profile after processed by the preinliner.
Not inlined context will all be merged currently. See the comment I added above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109111/new/

https://reviews.llvm.org/D109111



More information about the llvm-commits mailing list