[PATCH] D109068: Fix a missing memoryssa update in breakLoopBackedge

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 16:57:49 PDT 2021


reames added a comment.

In D109068#2977909 <https://reviews.llvm.org/D109068#2977909>, @asbirlea wrote:

> The reason the verification didn't trigger right after LoopDeletion is that it's under EXPENSIVE_CHECKS (in verifyOrderingDominationAndDefUses). MSSA is incorrect (without this change) after LoopDeletion.

FYI, this is not the sole issue.  I manually added a call to MSSA->verifyMemorySSA() unconditionally to the end of the pass, and it did not catch this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109068/new/

https://reviews.llvm.org/D109068



More information about the llvm-commits mailing list