[PATCH] D109033: [InlineCost] Introduce attributes to override InlineCost for inliner testing

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin accepted this revision.
mtrofin added a comment.
This revision is now accepted and ready to land.

lgtm, some nits



================
Comment at: llvm/lib/Analysis/InlineCost.cpp:165
+Optional<int> getStringFnAttrAsInt(CallBase &CB, StringRef AttrKind) {
+  return stringAttrAsInt(getFnAttr(CB, AttrKind));
+}
----------------
why not move stringAttrAsInt here? has no other callers, and getStringFnAttrAsInt is just calling it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109033/new/

https://reviews.llvm.org/D109033