[PATCH] D109019: [CMake] Add targets for generating coverage reports

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: llvm/cmake/modules/CoverageReport.cmake:2
+# if coverage reports are not enabled, skip all of this
+if (NOT LLVM_BUILD_INSTRUMENTED_COVERAGE)
+  return()
----------------
LLVM tends to use `if(...)` as the style, please uniformly use that across the file.


================
Comment at: llvm/cmake/modules/CoverageReport.cmake:7
+# Find the coverage artifact generator file
+find_file(PREPARE_CODE_COV_ARTIFACT
+          "utils/prepare-code-coverage-artifact.py"
----------------
Do you really expect users to provide an alternate implementation of this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109019/new/

https://reviews.llvm.org/D109019