[PATCH] D109053: [BitcodeReader] Delay select until all constants resolved

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:2734
+                                  Record[2], NextCstNo});
+      ++NextCstNo;
+      continue;
----------------
Maybe it would simplify the algorithm if you `ValueList.getConstantFwdRef(NextCstNo, CurTy);` here?  That way, indexing into ValueList later would never fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109053/new/

https://reviews.llvm.org/D109053