[PATCH] D108394: add tsan shared library

[Dan Albert via Phabricator via llvm-commits]

danalbert added inline comments.


================
Comment at: compiler-rt/lib/tsan/CMakeLists.txt:266
                                        clang_rt.tsan_cxx-${arch})
+    add_compiler_rt_runtime(clang_rt.tsan
+      SHARED
----------------
eugenis wrote:
> vitalybuka wrote:
> > @eugenis I would say that we need to test dynamic runtime, but I noticed that we test Asan but don't hwasan and ubsan. Is there good reason for that or just overlook?
> We test hwasan on android, it defaults to shared runtime there. As well as all sanitizers, I believe.
> 
> Yeah, it would be good to add such testing.
> 
We're working on testing on our end as well. TSan doesn't actually work on Android currently, but I don't think that's related to it being a shared library. TSan //was// working on Android as a shared library many years ago, but it bit rot because it never got used or tested.

Is there support for cross-testing in compiler-rt? If so we can add some tests here as well.


================
Comment at: libcxx/utils/merge_archives.py:11
 from argparse import ArgumentParser
+from ctypes.util import find_library
 import distutils.spawn
----------------
vitalybuka wrote:
> Why do we need this change?
We don't. This is an accidental revert due to a merge resolution, I think.

@ZijunZhao, need to update the review to exclude this part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108394/new/

https://reviews.llvm.org/D108394